dpgaspar commented on code in PR #20903:
URL: https://github.com/apache/superset/pull/20903#discussion_r946801284
##########
superset/reports/notifications/base.py:
##########
@@ -32,6 +32,7 @@ class NotificationContent:
description: Optional[str] = ""
url: Optional[str] = None # url to chart/dashboard for this screenshot
embedded_data: Optional[pd.DataFrame] = None
+ header_data: Optional[Dict[Any, Any]] = field(default_factory=lambda: {})
Review Comment:
nit: does `Optional` make sense here?
also can we flesh out the `Dict[Any, Any]` with a `dataclass` or
`TypedDict`. If not it should be `Dict[str, Any]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
