AAfghahi commented on code in PR #20903:
URL: https://github.com/apache/superset/pull/20903#discussion_r948479569
##########
superset/utils/core.py:
##########
@@ -184,6 +184,15 @@ class DatasourceType(str, Enum):
VIEW = "view"
+class HeaderDataType(TypedDict):
+ notification_format: str
+ owners: List[int]
+ notification_type: str
+ notification_source: Optional[str]
+ chart_id: Optional[int]
+ dashboard_id: Optional[int]
Review Comment:
Type and format shouldn't be since they are required in order to make a
report. I can make all of them optional however.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
