AAfghahi commented on code in PR #20903:
URL: https://github.com/apache/superset/pull/20903#discussion_r946895274
##########
superset/config.py:
##########
@@ -1066,6 +1066,12 @@ def SQL_QUERY_MUTATOR( # pylint:
disable=invalid-name,unused-argument
return sql
+def NOTIFICATION_EMAIL_HEADER_MUTATOR( # pylint:
disable=invalid-name,unused-argument
+ msg: Dict[str, Any], **kwargs: Any
Review Comment:
One reason we went with `**kwargs` was so that we could keep the information
going into the mutator broad and then put the onus of structuring the data on
the mutator in `superset_config`. Though thinking about it, this same thought
pattern would exist with a `Dict` named parameter. Though in those cases the
mutator class would have to account for newer changes, yeah.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
