villebro commented on code in PR #21065: URL: https://github.com/apache/superset/pull/21065#discussion_r947923915
########## superset/views/database/forms.py: ########## @@ -39,6 +40,12 @@ ) from superset.models.core import Database + +class DatabasesNotAllowedToFileUpload(str, Enum): + GSHEETS = "gsheets" + CLICKHOUSE = "clickhousedb" Review Comment: I agree with @nytai here - we should place this flag in the db engine specs, and the UI should accommodate accordingly. I may be wrong, but I believe we're already sending some db engine spec metadata in bootstrap data. Maybe we could just add `allows_file_upload` to `BaseEngineSpec`, override it in the GSheets and ClickHouse specs, and then make sure the flag is made available in bootstrap data? If we're not passing any info about db engine specs, now would probably be a good time to do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
