Antonio-RiveroMartnez commented on code in PR #21065: URL: https://github.com/apache/superset/pull/21065#discussion_r948122969
########## superset/views/database/forms.py: ########## @@ -39,6 +40,12 @@ ) from superset.models.core import Database + +class DatabasesNotAllowedToFileUpload(str, Enum): + GSHEETS = "gsheets" + CLICKHOUSE = "clickhousedb" Review Comment: Hey @nytai @villebro! Yeah, currently the flag is being set in our `BaseEngineSpec` and being overridden in our `GSheets` and `Clickhouse` specs. The missing part is sending it (or using it) in the frontend instead of `db?.engine !== Engines.GSheet && db?.engine !== Engines.ClickHouse`. So, let me check the bootstrap data and if not doing it already let me start sending it. Thank you both for the input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
