Antonio-RiveroMartnez commented on code in PR #21065: URL: https://github.com/apache/superset/pull/21065#discussion_r949640424
########## superset/views/database/forms.py: ########## @@ -39,6 +40,12 @@ ) from superset.models.core import Database + +class DatabasesNotAllowedToFileUpload(str, Enum): + GSHEETS = "gsheets" + CLICKHOUSE = "clickhousedb" Review Comment: Ok @nytai @villebro , I updated the PR, we were sending some `extra` information in the response but that might is editable by the user so I decided to include a new `engine_information` that currently only has `allows_file_upload` flag. Now, There is no need for updating multiple places but instead just setting such flags as true to prevent file uploading. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
