kgabryje opened a new pull request, #21114:
URL: https://github.com/apache/superset/pull/21114

   
   ### SUMMARY
   When user added more than 1 filter with custom SQL and saved the chart, all 
filters with custom SQL except for the first one disappeared. This PR fixes 
that issue.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   
https://user-images.githubusercontent.com/15073128/185192610-40a9c076-7540-4818-a6b2-b89d1b20c84f.mov
   
   After:
   
   
https://user-images.githubusercontent.com/15073128/185192803-44626ed7-e1c6-42e6-ab09-41a7b464c44a.mov
   
   ### TESTING INSTRUCTIONS
   1. Open explore and add a few filters with custom sql
   2. Save chart
   3. All added filters should still be there
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to