michael-s-molina commented on code in PR #21114:
URL: https://github.com/apache/superset/pull/21114#discussion_r948263505
##########
superset-frontend/src/explore/controlUtils/getFormDataWithDashboardContext.ts:
##########
@@ -51,28 +54,34 @@ const simpleFilterToAdhoc = (
return result;
};
-const removeAdhocFilterDuplicates = (filters: SimpleAdhocFilter[]) => {
+const removeAdhocFilterDuplicates = (filters: AdhocFilter[]) => {
const isDuplicate = (
- adhocFilter: SimpleAdhocFilter,
- existingFilters: SimpleAdhocFilter[],
+ adhocFilter: AdhocFilter,
+ existingFilters: AdhocFilter[],
) =>
existingFilters.some(
- (existingFilter: SimpleAdhocFilter) =>
- existingFilter.operator === adhocFilter.operator &&
- existingFilter.subject === adhocFilter.subject &&
- ((!('comparator' in existingFilter) &&
- !('comparator' in adhocFilter)) ||
- ('comparator' in existingFilter &&
- 'comparator' in adhocFilter &&
- isEqual(existingFilter.comparator, adhocFilter.comparator))),
+ (existingFilter: AdhocFilter) =>
Review Comment:
Can we split this code into equality functions for each filter type to
improve readability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
