kgabryje commented on code in PR #21114:
URL: https://github.com/apache/superset/pull/21114#discussion_r948219561
##########
superset-frontend/src/explore/controlUtils/getFormDataWithDashboardContext.ts:
##########
@@ -176,16 +185,28 @@ export const getFormDataWithDashboardContext = (
exploreFormData,
dashboardContextFormData,
);
- const adhocFilters = removeAdhocFilterDuplicates([
- ...ensureIsArray(exploreFormData.adhoc_filters),
- ...ensureIsArray(filterBoxData.adhoc_filters),
- ...ensureIsArray(nativeFiltersData.adhoc_filters),
- ]);
+ const adhocFilters = [
+ ...Object.keys(exploreFormData),
+ ...Object.keys(filterBoxData),
+ ...Object.keys(nativeFiltersData),
+ ]
+ .filter(key => key.match(/adhoc_filter.*/))
Review Comment:
handles the case of fields like `adhoc_filters_b` in mixed chart. Logic
similar to `superset/utils/core.py`, line 1121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
