AAfghahi commented on code in PR #20903:
URL: https://github.com/apache/superset/pull/20903#discussion_r948480448
##########
superset/reports/notifications/base.py:
##########
@@ -21,11 +21,15 @@
import pandas as pd
from superset.reports.models import ReportRecipients, ReportRecipientType
+from superset.utils.core import HeaderDataType
@dataclass
class NotificationContent:
name: str
+ header_data: Optional[
+ HeaderDataType
+ ] = None # this is optional to account for error states
Review Comment:
Yeah, we also create notification_content when there is an error, should we
be pushing header data into those cases as well? I assumed we wouldn't be but
happy to make it not optional, and create header data in those instances as
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
