Antonio-RiveroMartnez commented on code in PR #21790:
URL: https://github.com/apache/superset/pull/21790#discussion_r1000983941
##########
superset/models/core.py:
##########
@@ -362,6 +362,18 @@ def get_effective_user(self, object_url: URL) ->
Optional[str]:
else None
)
+ @contextmanager
+ def get_sqla_engine_with_context(
Review Comment:
What is the difference between having this new
`get_sqla_engine_with_context` with the decorator VS using it in our existing
`get_sqla_engine` ? I Mean, couldn't we just use the existing one and make use
or not of the new functionality the decorator brings when needed? or would that
mean changing a ton of places where the `get_sqla_engine` is being used right
now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
