Antonio-RiveroMartnez commented on code in PR #21790:
URL: https://github.com/apache/superset/pull/21790#discussion_r1000988199
##########
tests/integration_tests/model_tests.py:
##########
@@ -57,30 +57,36 @@ def test_database_schema_presto(self):
sqlalchemy_uri = "presto://presto.airbnb.io:8080/hive/default"
model = Database(database_name="test_database",
sqlalchemy_uri=sqlalchemy_uri)
- db = make_url(model.get_sqla_engine().url).database
- self.assertEqual("hive/default", db)
+ with model.get_sqla_engine_with_context() as engine:
+ db = make_url(engine.url).database
+ self.assertEqual("hive/default", db)
- db = make_url(model.get_sqla_engine(schema="core_db").url).database
- self.assertEqual("hive/core_db", db)
+ with model.get_sqla_engine_with_context(schema="core_db") as engine:
+ db = make_url(engine.url).database
+ self.assertEqual("hive/core_db", db)
sqlalchemy_uri = "presto://presto.airbnb.io:8080/hive"
model = Database(database_name="test_database",
sqlalchemy_uri=sqlalchemy_uri)
- db = make_url(model.get_sqla_engine().url).database
- self.assertEqual("hive", db)
+ with model.get_sqla_engine_with_context() as engine:
+ db = make_url(engine.url).database
+ self.assertEqual("hive", db)
- db = make_url(model.get_sqla_engine(schema="core_db").url).database
- self.assertEqual("hive/core_db", db)
+ with model.get_sqla_engine_with_context(schema="core_db") as engine:
+ db = make_url(engine.url).database
+ self.assertEqual("hive/core_db", db)
def test_database_schema_postgres(self):
sqlalchemy_uri = "postgresql+psycopg2://postgres.airbnb.io:5439/prod"
model = Database(database_name="test_database",
sqlalchemy_uri=sqlalchemy_uri)
- db = make_url(model.get_sqla_engine().url).database
- self.assertEqual("prod", db)
+ with model.get_sqla_engine_with_context() as engine:
+ db = make_url(engine.url).database
Review Comment:
I see we have this `make_url_safe` here: `superset/databases/utils.py`,
would that serve the same purpose? If so, can we change to that one or must we
keep using this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
