[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #21790: feat: create function for get_sqla_engine with context

Thu, 20 Oct 2022 19:38:37 -0700 


Antonio-RiveroMartnez commented on code in PR #21790:
URL: https://github.com/apache/superset/pull/21790#discussion_r1001301308


##########
superset/models/core.py:
##########
@@ -362,6 +362,18 @@ def get_effective_user(self, object_url: URL) -> 
Optional[str]:
             else None
         )
 
+    @contextmanager
+    def get_sqla_engine_with_context(

Review Comment:
   Oh ok ok, makes sense then 😎 thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to