Yann-J commented on code in PR #21806:
URL: https://github.com/apache/superset/pull/21806#discussion_r1003130423
##########
helm/superset/values.yaml:
##########
@@ -267,20 +267,18 @@ supersetNode:
# -- If true, forces deployment to reload on each upgrade
forceReload: false
# -- Init containers
- # @default -- a container waiting for postgres to be up
+ # @default -- a container waiting for postgres
initContainers:
- name: wait-for-postgres
- image: "{{ .Values.initImage.repository }}:{{ .Values.initImage.tag }}"
- imagePullPolicy: "{{ .Values.initImage.pullPolicy }}"
+ image: jwilder/dockerize
Review Comment:
Yeah, this is a good catch, and I probably should have mentioned it. I've
hesitated on the best approach here.
The reason I'm not using the provided values, is to avoid risks of
regressions, if, for some reason, someone has overridden these keys, the
`dockerize` command will fail.
I don't think there's really any strong reason to be overriding these, but
it's possible...
There might be a more elegant way to manage this potentially breaking
change...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
