Yann-J commented on code in PR #21806:
URL: https://github.com/apache/superset/pull/21806#discussion_r1004268097
##########
helm/superset/values.yaml:
##########
@@ -267,20 +267,18 @@ supersetNode:
# -- If true, forces deployment to reload on each upgrade
forceReload: false
# -- Init containers
- # @default -- a container waiting for postgres to be up
+ # @default -- a container waiting for postgres
initContainers:
- name: wait-for-postgres
- image: "{{ .Values.initImage.repository }}:{{ .Values.initImage.tag }}"
- imagePullPolicy: "{{ .Values.initImage.pullPolicy }}"
+ image: jwilder/dockerize
Review Comment:
It is already all configurable, as the entire `initContainers` section is
provided in the `values.yaml`. The default can be overridden directly. It's
just that it won't be using `initImage.repository`, but rather
`supersetNode.initContainers[0].image`.
The version will definitely be bumped, as I think chart versions should be
immutable. I believe the chart release process will ensure this anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
