Yann-J commented on code in PR #21806:
URL: https://github.com/apache/superset/pull/21806#discussion_r1004270987


##########
helm/superset/values.yaml:
##########
@@ -267,20 +267,18 @@ supersetNode:
   # -- If true, forces deployment to reload on each upgrade
   forceReload: false
   # -- Init containers
-  # @default -- a container waiting for postgres to be up
+  # @default -- a container waiting for postgres
   initContainers:
     - name: wait-for-postgres
-      image: "{{ .Values.initImage.repository }}:{{ .Values.initImage.tag }}"
-      imagePullPolicy: "{{ .Values.initImage.pullPolicy }}"
+      image: jwilder/dockerize

Review Comment:
   To reduce a bit the redundancy, we can use `initImage.repository` as a 
default, but still leave the possibility to independently override it 
separately for each deployment...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to