kgabryje commented on code in PR #22474:
URL: https://github.com/apache/superset/pull/22474#discussion_r1080938588
##########
superset-frontend/src/dashboard/components/menu/WithPopoverMenu.tsx:
##########
@@ -41,6 +42,67 @@ interface WithPopoverMenuState {
isFocused: Boolean;
}
+const WithPopoverMenuStyles = styled.div`
+ ${({ theme }) => css`
+ position: relative;
+ outline: none;
+
+ &.with-popover-menu--focused:after {
+ content: '';
+ position: absolute;
+ top: 0;
+ left: 0;
+ width: 100%;
+ height: 100%;
+ border: 2px solid ${theme.colors.primary.base};
Review Comment:
It's this border when component is focused in edit mode. Looks weird with 1px
<img width="167" alt="image"
src="https://user-images.githubusercontent.com/15073128/213391595-6f1ec994-d44b-437a-892f-1fae6d5d80d8.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/15073128/213391595-6f1ec994-d44b-437a-892f-1fae6d5d80d8.png"](https://user-images.githubusercontent.com/15073128/213391595-6f1ec994-d44b-437a-892f-1fae6d5d80d8.png"){kind=link}