kgabryje commented on code in PR #22474:
URL: https://github.com/apache/superset/pull/22474#discussion_r1080940298
##########
superset-frontend/src/dashboard/components/menu/WithPopoverMenu.tsx:
##########
@@ -41,6 +42,67 @@ interface WithPopoverMenuState {
isFocused: Boolean;
}
+const WithPopoverMenuStyles = styled.div`
+ ${({ theme }) => css`
+ position: relative;
+ outline: none;
+
+ &.with-popover-menu--focused:after {
+ content: '';
+ position: absolute;
+ top: 0;
+ left: 0;
+ width: 100%;
+ height: 100%;
+ border: 2px solid ${theme.colors.primary.base};
+ pointer-events: none;
+ }
+
+ .dashboard-component-tabs li &.with-popover-menu--focused:after {
+ top: ${theme.gridUnit * -3}px;
+ left: ${theme.gridUnit * -2}px;
+ width: calc(100% + ${theme.gridUnit * 4}px);
+ height: calc(100% + ${theme.gridUnit * 7}px);
+ }
+ `}
+`;
+
+const PopoverMenuStyles = styled.div`
+ ${({ theme }) => css`
+ position: absolute;
+ flex-wrap: nowrap;
+ left: 1px;
+ top: -42px;
Review Comment:
Yes it should be in gridUnits. It's related to component's height (40px or
10gridUnits)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
