hughhhh commented on code in PR #23004:
URL: https://github.com/apache/superset/pull/23004#discussion_r1098113431
##########
superset/models/slice.py:
##########
@@ -160,11 +160,13 @@ def datasource_link(self) -> Optional[Markup]:
@renders("datasource_url")
def datasource_url(self) -> Optional[str]:
- # pylint: disable=no-member
if self.table:
return self.table.explore_url
datasource = self.datasource
- return datasource.explore_url if datasource else None
+ try:
Review Comment:
can we move this logic to the model instead in the Slice?
This issue is happening since the Query object doesn't have a definition for
`explore_url` so we need to add the implementation to the `ExploreMixin`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
