hughhhh commented on code in PR #23004:
URL: https://github.com/apache/superset/pull/23004#discussion_r1100669830
##########
superset/models/helpers.py:
##########
@@ -750,13 +750,30 @@ def columns(self) -> List[Any]:
def get_fetch_values_predicate(self) -> List[Any]:
raise NotImplementedError()
+ @property
+ def default_endpoint(self) -> sa.Text:
+ raise NotImplementedError()
+
+ @property
+ def type(self) -> str:
+ raise NotImplementedError()
+
+ @property
+ def id(self) -> int:
+ raise NotImplementedError()
+
@staticmethod
def get_extra_cache_keys(query_obj: Dict[str, Any]) -> List[str]:
raise NotImplementedError()
def get_template_processor(self, **kwargs: Any) -> BaseTemplateProcessor:
raise NotImplementedError()
+ def explore_url(self) -> str:
Review Comment:
> @hughhhh is this property needed in order to run a query?
it's not needed to run the for what I can see
> we may want to consider putting a constraint on slice.datasource_type so
that we only save charts that have a datasource_type of table.
thats does seem proper to stop charts from being created with the wrong type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
