hughhhh commented on code in PR #23004:
URL: https://github.com/apache/superset/pull/23004#discussion_r1100670463


##########
superset/models/helpers.py:
##########
@@ -750,13 +750,30 @@ def columns(self) -> List[Any]:
     def get_fetch_values_predicate(self) -> List[Any]:
         raise NotImplementedError()
 
+    @property
+    def default_endpoint(self) -> sa.Text:
+        raise NotImplementedError()
+
+    @property

Review Comment:
   i don't think we need type here since it's already defined in both 
datasources



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to