eschutho commented on code in PR #23003:
URL: https://github.com/apache/superset/pull/23003#discussion_r1100483468
##########
superset/utils/urls.py:
##########
@@ -48,7 +48,9 @@ def modify_url_query(url: str, **kwargs: Any) -> str:
v = [v]
params[k] = v
- parts[3] = "&".join(f"{k}={urllib.parse.quote(v[0])}" for k, v in
params.items())
+ parts[3] = "&".join(
+ f"{k}={urllib.parse.quote(str(v[0]))}" for k, v in params.items()
Review Comment:
when I passed an integer to this util in a new test it errored here, so I
covered this case by converting the value to a string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
