eschutho commented on code in PR #23003:
URL: https://github.com/apache/superset/pull/23003#discussion_r1100484854
##########
tests/integration_tests/reports/commands_tests.py:
##########
@@ -767,11 +763,9 @@ def test_email_chart_report_schedule_force_screenshot(
)
# assert that the link sent is correct
assert (
- '<a href="http://0.0.0.0:8080/explore/?'
- "form_data=%7B%22slice_id%22%3A%20"
- f"{create_report_email_chart_force_screenshot.chart.id}%7D&"
- 'standalone=0&force=true">Explore in Superset</a>'
- in email_mock.call_args[0][2]
+ '<a
href="http://0.0.0.0:8080/explore/?form_data=%7B%22slice_id%22%3A+'
+ f"{create_report_email_chart_force_screenshot.chart.id}"
+ '%7D&force=true">Explore in Superset</a>' in
email_mock.call_args[0][2]
Review Comment:
aside from removing standalone=0, which doesn't do anything in the page
load, the changes also turned `slice_id%22%3A%20` into `slice_id%22%3A+` but
when I tested this url live from a report, it still renders the chart
correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
