eschutho commented on code in PR #23003:
URL: https://github.com/apache/superset/pull/23003#discussion_r1100488903
##########
superset/cli/thumbnails.py:
##########
@@ -94,13 +93,7 @@ def compute_generic_thumbnail(
action = "Processing"
msg = f'{action} {friendly_type} "{model}" ({i+1}/{count})'
click.secho(msg, fg="green")
- if friendly_type == "chart":
- url = get_url_path(
- "Superset.slice", slice_id=model.id, standalone="true"
- )
- else:
- url = get_url_path("Superset.dashboard",
dashboard_id_or_slug=model.id)
- func(url, model.digest, force=force)
+ func(None, model.id, force=force)
Review Comment:
the cache thumbnail functions here take a user id, model Id and optional
force arguments. I'm not sure why we were passing url and digest here, but I
wrote a test below that asserted that we should be passing the correct args.
This might be worth testing to see how this was working before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
