eschutho commented on code in PR #23255:
URL: https://github.com/apache/superset/pull/23255#discussion_r1122502928
##########
superset/utils/webdriver.py:
##########
@@ -219,15 +217,16 @@ def get_screenshot(
img = element.screenshot_as_png
except TimeoutException:
- logger.warning("Selenium timed out requesting url %s", url,
exc_info=True)
+ logger.exception("Selenium timed out requesting url %s", url)
Review Comment:
This is going to give us a lot of errors in the application that aren't
necessarily system errors, but could be a result of a user error or an issue
with a user's database performance. Are we sure we want to log these as
exceptions? I'm currently seeing the stack trace under exc_info in the logs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
