eschutho commented on code in PR #23255:
URL: https://github.com/apache/superset/pull/23255#discussion_r1127229970
##########
superset/utils/webdriver.py:
##########
@@ -219,15 +217,16 @@ def get_screenshot(
img = element.screenshot_as_png
except TimeoutException:
- logger.warning("Selenium timed out requesting url %s", url,
exc_info=True)
+ logger.exception("Selenium timed out requesting url %s", url)
Review Comment:
That makes sense. I think some of these could be user-related, as in the
user's dataset is broken. Maybe we can split out the errors to get a better
sense of what's going on, and separate out the system errors from the user
errors. I put together a PR here.. lmk what you think.
https://github.com/apache/superset/pull/23290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
