craig-rueda commented on code in PR #23255:
URL: https://github.com/apache/superset/pull/23255#discussion_r1122549939
##########
superset/utils/webdriver.py:
##########
@@ -219,15 +217,16 @@ def get_screenshot(
img = element.screenshot_as_png
except TimeoutException:
- logger.warning("Selenium timed out requesting url %s", url,
exc_info=True)
+ logger.exception("Selenium timed out requesting url %s", url)
Review Comment:
I see what you're saying, but it's my opinion that exceptions should be
logged as such. If there's timeouts, we should adjust the timeout value in
order to prevent this. If there's some network issue, etc. we should look into
that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
