villebro commented on code in PR #23344:
URL: https://github.com/apache/superset/pull/23344#discussion_r1133753124
##########
superset-embedded-sdk/src/index.ts:
##########
@@ -116,6 +117,8 @@ export async function embedDashboard({
+ filterConfigKeys
.map(key => DASHBOARD_UI_FILTER_CONFIG_URL_PARAM_KEY[key] + '=' +
filterConfig[key]).join('&')
: ""
+ let extraUrlParams = new URLSearchParams(dashboardUiConfig?.urlParams ||
window.location.search).toString()
Review Comment:
Introducing this now could be seen as a breaking change and has security
implications, as it will start sending through all url params. How do you feel
about the following?
1. Adding the possibility of providing static mappings (the
`dashboardUiConfig?.urlParams` part in this PR).
2. Adding the possibility to let through all params (the
`window.location.search` part in this PR).
3. Adding the possibility to allowlist specific URL params (not made
possible here)
I think we should not assume 2 unless it's been explicitly allowed. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
