jileeon commented on code in PR #23344:
URL: https://github.com/apache/superset/pull/23344#discussion_r1144133375
##########
superset-embedded-sdk/src/index.ts:
##########
@@ -116,6 +117,8 @@ export async function embedDashboard({
+ filterConfigKeys
.map(key => DASHBOARD_UI_FILTER_CONFIG_URL_PARAM_KEY[key] + '=' +
filterConfig[key]).join('&')
: ""
+ let extraUrlParams = new URLSearchParams(dashboardUiConfig?.urlParams ||
window.location.search).toString()
Review Comment:
Hi @villebro, I've been thinking...
How about **passing query parameters which has prefix(like '`superset__`')**
for Superset Embedded Dashboard.
It can cover problems that we are aware of.
I think it's better. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
