jileeon commented on code in PR #23344:
URL: https://github.com/apache/superset/pull/23344#discussion_r1134751532
##########
superset-embedded-sdk/src/index.ts:
##########
@@ -116,6 +117,8 @@ export async function embedDashboard({
+ filterConfigKeys
.map(key => DASHBOARD_UI_FILTER_CONFIG_URL_PARAM_KEY[key] + '=' +
filterConfig[key]).join('&')
: ""
+ let extraUrlParams = new URLSearchParams(dashboardUiConfig?.urlParams ||
window.location.search).toString()
Review Comment:
Hi @villebro, I totally agree with your concern.
FYI, I appended the `window.location.search` part to make this feature more
intuitive. because most of the users expects that all url params on main page
will applied to embedded dashboard.
I think we should replace `window.location.search` with `{}`. and need to
provides more detailed instructions about it.
So we can cover 'General Case' and 'Special Case' I wrote above using
`Adding the possibility of providing static mappings`.
Thanks & Regards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
