cgivre commented on issue #6610: Add support to Apache Drill URL: https://github.com/apache/incubator-superset/pull/6610#issuecomment-477789775 Hi @kristw I do not believe that this PR will introduce any instability or is not production ready. As I indicated, it passes all the unit tests and works perfectly when I've used it myself. The remaining issue is that @mistercrunch prefers to have code that is specific to one database in the `db_engine_specs.py` file. (Which makes perfect sense and something I completely understand) However, there are two places in this PR that I could not get to work without putting database specific code into another file. If someone can show me how I can fix that, I will gladly do so, but I'm really stuck at this point. As I said, I do feel this PR is solid and ready to be merged. I'm willing to keep working on it to figure out how to move this code to the `db_engine_specs.py` file.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
