michael-s-molina commented on code in PR #24301:
URL: https://github.com/apache/superset/pull/24301#discussion_r1232179622
##########
superset/queries/saved_queries/dao.py:
##########
@@ -44,3 +47,20 @@ def bulk_delete(models: Optional[list[SavedQuery]], commit:
bool = True) -> None
except SQLAlchemyError as ex:
db.session.rollback()
raise DAODeleteFailedError() from ex
+
+ @classmethod
+ def get_by_id(cls, _id: str) -> Optional[SavedQuery]:
Review Comment:
If we think we need to change the way we identify resources because of
security or portability concerns, we need to write a SIP about it because it
will greatly impact the application (URL representation, APIs, storage, etc).
We also need to check if UUIDs meet the security criteria or if we need a more
secure approach that is also portable.
UUIDs are merely resource identifiers, similar to a sequential ID. They
shouldn't have a different meaning in terms of security like @john-bodley
mentioned above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
