eschutho commented on code in PR #24301:
URL: https://github.com/apache/superset/pull/24301#discussion_r1232637339
##########
superset/queries/saved_queries/dao.py:
##########
@@ -44,3 +47,20 @@ def bulk_delete(models: Optional[list[SavedQuery]], commit:
bool = True) -> None
except SQLAlchemyError as ex:
db.session.rollback()
raise DAODeleteFailedError() from ex
+
+ @classmethod
+ def get_by_id(cls, _id: str) -> Optional[SavedQuery]:
Review Comment:
Agree that a SIP on this functionality is a good idea. We were planning to
write one up, I think @john-bodley is also interested in writing it. If we
think this PR is too premature at this point, what do you all think about us
reverting [this one
line](https://github.com/apache/superset/pull/21682/files#diff-1fe9f23910bda67f66ff7b5e9127cdaba0d304153a5246dbcb2d76d70d2e5a4fR1365)
back to the old api so that we can fix the sharing capabilities that are
currently broken, and then we can talk about a longer-term solution in an
upcoming SIP? cc @hughhhh who is also helping on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
