john-bodley commented on code in PR #24466:
URL: https://github.com/apache/superset/pull/24466#discussion_r1235912485
##########
superset/daos/annotation.py:
##########
@@ -67,21 +51,6 @@ def validate_update_uniqueness(
class AnnotationLayerDAO(BaseDAO):
model_cls = AnnotationLayer
- @staticmethod
- def bulk_delete(
Review Comment:
Copypasta except the `BaseDAO` is defined as a `classmethod` as opposed to a
`staticmethod`.
##########
superset/daos/css.py:
##########
@@ -15,31 +15,12 @@
# specific language governing permissions and limitations
# under the License.
import logging
-from typing import Optional
-
-from sqlalchemy.exc import SQLAlchemyError
from superset.daos.base import BaseDAO
-from superset.daos.exceptions import DAODeleteFailedError
-from superset.extensions import db
from superset.models.core import CssTemplate
logger = logging.getLogger(__name__)
class CssTemplateDAO(BaseDAO):
model_cls = CssTemplate
-
- @staticmethod
Review Comment:
Copypasta except the `BaseDAO` is defined as a `classmethod` as opposed to a
`staticmethod`.
##########
superset/daos/annotation.py:
##########
@@ -30,19 +27,6 @@
class AnnotationDAO(BaseDAO):
model_cls = Annotation
- @staticmethod
Review Comment:
Copypasta except the `BaseDAO` is defined as a `classmethod` as opposed to a
`staticmethod`.
##########
superset/daos/annotation.py:
##########
@@ -67,21 +51,6 @@ def validate_update_uniqueness(
class AnnotationLayerDAO(BaseDAO):
model_cls = AnnotationLayer
- @staticmethod
Review Comment:
Same logic as the `BaseDAO`, though was defined as a static-method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
