john-bodley commented on code in PR #24466:
URL: https://github.com/apache/superset/pull/24466#discussion_r1237973991
##########
superset/daos/dataset.py:
##########
@@ -361,24 +359,27 @@ def create_metric(
"""
return DatasetMetricDAO.create(properties, commit=commit)
- @staticmethod
- def bulk_delete(models: Optional[list[SqlaTable]], commit: bool = True) ->
None:
- item_ids = [model.id for model in models] if models else []
+ @classmethod
+ def delete(
Review Comment:
The `bulk_deletion` logic differs from the `delete` logic in the sense that
the former first deletes the relationships (which in actuality may not be
explicitly required) before deleting the dataset, whereas the later only
deletes the datasets (which in theory _should_ delete all the records with an
explicit relationship).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
