michael-s-molina commented on code in PR #24466:
URL: https://github.com/apache/superset/pull/24466#discussion_r1254366942
##########
superset/daos/base.py:
##########
@@ -180,25 +183,28 @@ def update(cls, model: T, properties: dict[str, Any],
commit: bool = True) -> T:
return model
@classmethod
- def delete(cls, model: T, commit: bool = True) -> T:
+ def delete(cls, items: T | list[T], commit: bool = True) -> None:
"""
- Generic delete a model
- :raises: DAODeleteFailedError
+ Delete the specified items(s) including their associated relationships.
Review Comment:
```suggestion
Delete the specified item(s) including their associated
relationships.
```
##########
superset/daos/annotation.py:
##########
@@ -67,21 +51,6 @@ def validate_update_uniqueness(
class AnnotationLayerDAO(BaseDAO):
model_cls = AnnotationLayer
- @staticmethod
- def bulk_delete(
Review Comment:
Nice cleanup!
##########
superset/daos/annotation.py:
##########
@@ -30,19 +27,6 @@
class AnnotationDAO(BaseDAO):
model_cls = Annotation
- @staticmethod
Review Comment:
These comments are very helpful while reviewing. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
