john-bodley commented on code in PR #24488:
URL: https://github.com/apache/superset/pull/24488#discussion_r1239297169
##########
tests/integration_tests/sqla_models_tests.py:
##########
@@ -430,7 +425,7 @@ def test_multiple_sql_statements_raises_exception(self):
}
table = SqlaTable(
- table_name="test_has_extra_cache_keys_table",
+ table_name="test_multiple_sql_statements",
Review Comment:
See my comment above. SQLite was complaining that said table already existed
when I removed the "cleanup", though neither MySQL nor PostgreSQL did. I'm not
entirely sure what's going on here, but it does seem like the table name was
copypasta from the other test and thus the easiest solution was to rename the
table in accordance with the test.
I sense with this refactoring work it's a case of two steps forwards, one
step back at time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
