john-bodley commented on code in PR #24488:
URL: https://github.com/apache/superset/pull/24488#discussion_r1239082684
##########
superset/daos/dataset.py:
##########
@@ -364,17 +364,6 @@ def create_metric(
@staticmethod
def bulk_delete(models: Optional[list[SqlaTable]], commit: bool = True) ->
None:
item_ids = [model.id for model in models] if models else []
- # bulk delete, first delete related data
Review Comment:
This is no longer needed as the database will handle said logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
