craig-rueda commented on code in PR #24488: URL: https://github.com/apache/superset/pull/24488#discussion_r1240077021
########## superset/migrations/versions/2023-06-22_13-39_6fbe660cac39_add_on_delete_cascade_for_tables_references.py: ########## @@ -0,0 +1,94 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""add on delete cascade for tables references + +Revision ID: 6fbe660cac39 +Revises: 83e1abbe777f +Create Date: 2023-06-22 13:39:47.989373 + +""" +from __future__ import annotations + +# revision identifiers, used by Alembic. +revision = "6fbe660cac39" +down_revision = "83e1abbe777f" + +import sqlalchemy as sa +from alembic import op + +from superset.utils.core import generic_find_fk_constraint_name + + +def migrate(ondelete: str | None) -> None: + """ + Redefine the foreign key constraints, via a successive DROP and ADD, for all tables + related to the `tables` table to include the ON DELETE construct for cascading + purposes. + + :param ondelete: If set, emit ON DELETE <value> when issuing DDL for this constraint + """ + + bind = op.get_bind() + insp = sa.engine.reflection.Inspector.from_engine(bind) + + conv = { + "fk": "fk_%(table_name)s_%(column_0_name)s_%(referred_table_name)s", + } + + for table in ("sql_metrics", "table_columns"): Review Comment: 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
