betodealmeida opened a new pull request, #24921:
URL: https://github.com/apache/superset/pull/24921

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   Add a `df_to_sql` method to the GSheets DB engine spec, so we can upload CSV 
files. When a file is uploaded, a new sheet is created, and the database 
catalog is updated to point the table name to the URL of the new sheet.
   
   The user can also choose to replace an existing table, in which case the 
sheet gets cleared before the data is inserted.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   Inserting some data:
   
   ![Screenshot 2023-08-08 at 18-40-33 
Superset](https://github.com/apache/superset/assets/1534870/a2b2edfe-dd8c-4860-9885-494fc518a9ce)
   
   Querying the table:
   
   ![Screenshot 2023-08-08 at 18-42-05 
Superset](https://github.com/apache/superset/assets/1534870/1ec6429f-db88-479c-b984-b5da452050e8)
   
   Uploading a different CSV and replacing the table:
   
   ![Screenshot 2023-08-08 at 18-43-21 
Superset](https://github.com/apache/superset/assets/1534870/df119ffb-bf58-4bfb-8f25-3db58fcac9a8)
   
   And querying it (note that the metadata is cached and shows the old schema):
   
   ![Screenshot 2023-08-08 at 18-44-24 
Superset](https://github.com/apache/superset/assets/1534870/38dc15f6-86bd-4b41-bb02-013200d19d8b)
   
   And the sheet after the second upload:
   
   ![Screenshot 2023-08-08 at 18-44-46 
upload_test](https://github.com/apache/superset/assets/1534870/82c02133-59ed-4bb3-8893-cbd445c21805)
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to