betodealmeida commented on code in PR #24921:
URL: https://github.com/apache/superset/pull/24921#discussion_r1290882849
##########
superset/db_engine_specs/gsheets.py:
##########
@@ -57,7 +71,7 @@ class GSheetsParametersSchema(Schema):
class GSheetsParametersType(TypedDict):
service_account_info: str
- catalog: Optional[dict[str, str]]
+ catalog: dict[str, str] | None
Review Comment:
We bumped the minimum Python version we support in Superset (I think to
3.9?), and in it we can use the syntax `foo | None` instead of `Optional[foo]`.
This way we don't need to import `Optional`, and the type declaration looks
more natural (for example, it's similar to Typescript's `foo | null` for an
optional `foo`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
