Antonio-RiveroMartnez commented on code in PR #24921:
URL: https://github.com/apache/superset/pull/24921#discussion_r1290878333
##########
superset/db_engine_specs/gsheets.py:
##########
@@ -57,7 +71,7 @@ class GSheetsParametersSchema(Schema):
class GSheetsParametersType(TypedDict):
service_account_info: str
- catalog: Optional[dict[str, str]]
+ catalog: dict[str, str] | None
Review Comment:
Just curious why moving from `Optional` ? Because I see `Optional` being
used in several other `TypedDict` classes. Want to confirm if this is a pattern
we aim to follow moving forward, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
