ege-st commented on code in PR #24942:
URL: https://github.com/apache/superset/pull/24942#discussion_r1290658459
##########
superset/connectors/sqla/models.py:
##########
@@ -1011,7 +1013,7 @@ def adhoc_column_to_sqla( # pylint:
disable=too-many-locals
if is_dttm and has_timegrain:
sqla_column = self.db_engine_spec.get_timestamp_expr(
col=sqla_column,
- pdf=None,
+ pdf=pdf,
Review Comment:
Unfortunately, in my testing whenever I tried to create a chart or use a
dashboard, if a column was marked as `temporal` it would always call
`get_timestamp_expr` via `adhoc_column_to_sqla` which means that the user
defined date format is never passed to the DB Engine Spec.
It's possible that the root cause of the issue is that `get_timestamp_expr`
is being called through `adhoc_column_to_sqla` which it should be getting
called via `TableColumn.get_timestamp_expression` (the only other call path to
`get_timestamp_expr` I could find. But all my tests pointed to
`adhoc_column_to_sqla` being the root cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
