zhaoyongjie commented on code in PR #24942:
URL: https://github.com/apache/superset/pull/24942#discussion_r1290663501
##########
superset/connectors/sqla/models.py:
##########
@@ -1011,7 +1013,7 @@ def adhoc_column_to_sqla( # pylint:
disable=too-many-locals
if is_dttm and has_timegrain:
sqla_column = self.db_engine_spec.get_timestamp_expr(
col=sqla_column,
- pdf=None,
+ pdf=pdf,
Review Comment:
@john-bodley the "pdf" is a shortcut for "date format (seconds or
milliseconds)", this code was existing in many years, the "pdf" only used in
Calculated Column and Columns from database, but not used in Adhoc expression,
so we shouldn't make this change.
<img width="895" alt="image"
src="https://github.com/apache/superset/assets/2016594/4b6547bb-796e-4dd7-a2d5-07fcaff8b0a5";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
