ege-st commented on code in PR #24942:
URL: https://github.com/apache/superset/pull/24942#discussion_r1290718365
##########
superset/connectors/sqla/models.py:
##########
@@ -1011,7 +1013,7 @@ def adhoc_column_to_sqla( # pylint:
disable=too-many-locals
if is_dttm and has_timegrain:
sqla_column = self.db_engine_spec.get_timestamp_expr(
col=sqla_column,
- pdf=None,
+ pdf=pdf,
Review Comment:
@zhaoyongjie do we just update this code to use the driver at
https://github.com/BurdaForward/pinot-dbapi/tree/bf_release and that will allow
ad-hoc expressions to work with Pinot? Or do I change the existing driver to
follow the code snippet you provided above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
