giftig commented on PR #25746: URL: https://github.com/apache/superset/pull/25746#issuecomment-1782546848
That's a fair point @john-bodley; as I'm looking into this my gut feeling is that `PRESTO_EXPAND_DATA` built a feature into superset to account for it being missing in trino -- I think actually trino itself, even, rather than the python client. We're essentially working around two possible missing features in trino: 1. We can't ask trino to summarise the types of even the names of each field in a `ROW` for us 2. We can't ask trino to expand `ROW`s out for us itself which both feel like necessary features to have given it does let us descend into the row with a `dotted.path.syntax`. And, as I documented on my class here, there are edge cases where trino will break the format of its own type annotation by failing to quote column names containing spaces or brackets. I think I'm probably suffering from the same problem that the original author of the `PRESTO_EXPAND_DATA` feature did, which is that it's easier to contribute code to superset than to trino. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
