giftig commented on PR #25746:
URL: https://github.com/apache/superset/pull/25746#issuecomment-1784941909
Just to make sure context is clear on this one: the next steps, which I'm
now part way through, are:
- use this type information to extract out a full list of fields
descending into `ROW`s like `foo.bar.baz`
- update `get_columns` in trino to reflect these fields (probably behind a
new feature flag like `TRINO_EXPAND_ROWS`)
- this will then reflect these columns in SQL Lab table schema and preview
and allow for autocompletion
I intend to raise the above as a second PR based on this work, to make this
easier to review, as this is already fully encapsulated. This also means if we
do manage to have this capability shifted left as @john-bodley mentioned we can
throw out this component but keep part 2. I can raise the whole thing as one PR
if preferred though.
The original `PRESTO_EXPAND_DATA` feature did a little more than the above,
parsing and expanding data in SQL Lab results even on a `SELECT *` and also
trying to expand out `ARRAY`s, but I have doubts as to the value of that so
I'll disregard and keep this simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
