Vitor-Avila opened a new pull request, #26199: URL: https://github.com/apache/superset/pull/26199
### SUMMARY Avoid de-normalizing column names in case the engine supports it **but column normalization is enabled in the dataset level**. This is enabled by default to datasets created prior to this feature, to make sure that syncing columns wouldn't break existing charts/etc. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **Before** https://github.com/apache/superset/assets/96086495/f30e8688-81c8-4019-b10d-4e4aaef932f6 **After** https://github.com/apache/superset/assets/96086495/31909ae1-91b7-4710-9c9e-3f531a344821 ### TESTING INSTRUCTIONS 1. Create a dataset powered by an engine that supports column de-normalization (such as Snowflake). Note that: a. All columns are **uppercase**. b. Column normalization is disabled (under the **SETTINGS** tab). 2. Modify the dataset, and enable column normalization. 3. Save changes. 4. Modify the dataset again, and sync columns. Note that all columns are now **lowercase**. 5. Save changes. 6. Create a new chart using this dataset, and drop any column in the FILTERS section. 7. Validate the filter is showing available options in the dropdown. ### ADDITIONAL INFORMATION - [x] Has associated issue: Fixes https://github.com/apache/superset/issues/26198 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
