sadpandajoe commented on code in PR #26199:
URL: https://github.com/apache/superset/pull/26199#discussion_r1419345922
##########
superset/models/helpers.py:
##########
@@ -1340,14 +1340,19 @@ def get_time_filter( # pylint:
disable=too-many-arguments
)
return and_(*l)
- def values_for_column(self, column_name: str, limit: int = 10000) ->
list[Any]:
- # always denormalize column name before querying for values
+ def values_for_column(
Review Comment:
Do our unit tests already have cases where it covers if `denormalize_column`
returns the correct values for both true and false already? If not, I would add
tests to confirm that the correct things are returned for when the flag is true
since we're defaulting to false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
