Vitor-Avila commented on code in PR #26199:
URL: https://github.com/apache/superset/pull/26199#discussion_r1419930472
##########
superset/models/helpers.py:
##########
@@ -1340,14 +1340,19 @@ def get_time_filter( # pylint:
disable=too-many-arguments
)
return and_(*l)
- def values_for_column(self, column_name: str, limit: int = 10000) ->
list[Any]:
- # always denormalize column name before querying for values
+ def values_for_column(
Review Comment:
@sadpandajoe @villebro I just added some basic tests to
https://github.com/apache/superset/pull/26220 (since this one got merged). It
doesn't test the logic implemented in the DB engine level to denormalize a
column (I believe this is DB-specific and would require a more complex setup),
but should be at least testing the business logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
